Differential D2714

Remove outdated AbstractDataPlugin::setDelegate(QtQuick stuff)
ClosedPublic
Actions

Authored by kossebau on Sep 8 2016, 4:37 PM.

Details

Reviewers
sanjibanb
nienhueser
Group Reviewers
Marble
Commits
R34:567b7c1002e4: Remove outdated AbstractDataPlugin::setDelegate(QtQuick stuff)
Summary
  • subclass DeclarativeDataPlugin replaced that need
  • allows to drop dep of libmarblewidget to Qt5::Quick again

Follow-up for c9bf0b7712e127b5339b962c28aa469312320cf5

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 6559.Sep 8 2016, 4:37 PM
kossebau retitled this revision from to Remove outdated AbstractDataPlugin::setDelegate(QtQuick stuff).
kossebau updated this object.
kossebau added reviewers: Marble, nienhueser, sanjibanb.
nienhueser accepted this revision.Sep 8 2016, 7:14 PM
nienhueser edited edge metadata.

Looks fine.

This revision is now accepted and ready to land.Sep 8 2016, 7:14 PM
Closed by commit R34:567b7c1002e4: Remove outdated AbstractDataPlugin::setDelegate(QtQuick stuff) (authored by kossebau). · Explain WhySep 8 2016, 8:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6563

View Options

src/lib/marble/AbstractDataPlugin.h

Loading...
View Options

src/lib/marble/AbstractDataPlugin.cpp

Loading...
View Options

src/lib/marble/CMakeLists.txt

Loading...
View Options

src/lib/marble/MarbleConfig.cmake.in

Loading...
View Options

src/lib/marble/declarative/DeclarativeDataPlugin.h

Loading...