Replace the previous usages of integer 8 with 'nRows' and 'nCols'.
Details
Details
- Reviewers
aacid - Group Reviewers
KDE Games - Commits
- R411:918a00f28b7d: Add const values 'nRows' and 'nCols'
Diff Detail
Diff Detail
- Repository
- R411 KReversi
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| commondefs.h | ||
|---|---|---|
| 45 | static const -> constexpr | |
| commondefs.h | ||
|---|---|---|
| 45 | Thank you for your comment! But I doubt that change static const -> constexpr will have any improvement in performance or readability. Basic they are doing the same thing in this situation. I would still prefer using 'static const' because the code does not involve any computation in compile time. | |
| commondefs.h | ||
|---|---|---|
| 45 | Thank you for your comment! But I doubt that change static const -> constexpr will have any improvement in performance or readability. Basically they are doing the same thing in this situation. I would still prefer using 'static const' because the code does not involve any computation in compile time. | |