src/krcc.cpp
4	Same thing here
src/krcc.h
4	The original license doesn't make sense. If it's LGPL-2.0 or LGPL-3.0, the GPL 3 clause cannot be invoked This needs some code archeology to understand where the issue comes from

Thanks for the review, I requested David to clarify the license statement. (Unfortunately, exact this license statement is also used in different frameworks, but we will have to solve those issues when coming to there.)

src/krcc.h
4	Initially I thought that the text can be interpret directly in this sense, but after double-checking I agree with your reading. I sent a mail to the frameworks list, asking David for clarification of the license.

License statements with mixed usage of LGPL and GPL were clarified on mailing list.

src/krcc.cpp
4	clarified here that the conversion was correct: LGPL-2.0-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
src/krcc.h
4	license statement was clarified in this mail https://mail.kde.org/pipermail/kde-frameworks-devel/2020-February/103127.html to be LGPL-2.0-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL

krop accepted this revision.Feb 8 2020, 8:39 AM

This revision is now accepted and ready to land.Feb 8 2020, 8:39 AM

Closed by commit R243:8c40c6f028b3: Convert license statements to SPDX headers (authored by cordlandwehr). · Explain WhyFeb 8 2020, 8:45 AM

This revision was automatically updated to reflect the committed changes.

cordlandwehr mentioned this in T11550: Add SPDX License markers.Feb 8 2020, 8:46 AM

cordlandwehr retitled this revision from Convert license statements to SPDX headers to KArchive: Convert license statements to SPDX headers.Feb 8 2020, 10:30 AM

Revision Contents
Changeset List

		Path
A	M	LICENSES/BSD-2-Clause.txt (22 lines)
A	M	LICENSES/LGPL-2.0-only.txt (446 lines)
A	M	LICENSES/LGPL-2.0-or-later.txt (446 lines)
A	M	LICENSES/LGPL-3.0-only.txt (163 lines)
A	M	LICENSES/LicenseRef-KDE-Accepted-LGPL.txt (12 lines)
M		autotests/deprecatedtest.cpp (19 lines)
M		autotests/karchivetest.h (19 lines)
M		autotests/karchivetest.cpp (21 lines)
M		autotests/kcompressiondevicetest.h (17 lines)
M		autotests/kcompressiondevicetest.cpp (19 lines)
M		autotests/kfiltertest.h (16 lines)
M		autotests/kfiltertest.cpp (16 lines)
M		autotests/klimitediodevicetest.h (19 lines)
M		autotests/klimitediodevicetest.cpp (19 lines)
M		examples/bzip2gzip/main.cpp (27 lines)
M		examples/helloworld/main.cpp (25 lines)
M		examples/tarlocalfiles/main.cpp (25 lines)
M		examples/unzipper/main.cpp (25 lines)
M		src/k7zip.h (16 lines)
M		src/k7zip.cpp (16 lines)
M		src/kar.h (16 lines)
M		src/kar.cpp (16 lines)
M		src/karchive.h (18 lines)
M		src/karchive.cpp (18 lines)
M		src/karchive_p.h (18 lines)
M		src/karchivedirectory.h (18 lines)
M		src/karchiveentry.h (18 lines)
M		src/karchivefile.h (18 lines)
M		src/kbzip2filter.h (17 lines)
M		src/kbzip2filter.cpp (19 lines)
M		src/kcompressiondevice.h (20 lines)
M		src/kcompressiondevice.cpp (20 lines)
M		src/kcompressiondevice_p.h (18 lines)
M		src/kfilterbase.h (17 lines)
M		src/kfilterbase.cpp (17 lines)
M		src/kfilterdev.h (16 lines)
M		src/kfilterdev.cpp (16 lines)
M		src/kgzipfilter.h (17 lines)
M		src/kgzipfilter.cpp (19 lines)
M		src/klimitediodevice.cpp (16 lines)
M		src/klimitediodevice_p.h (16 lines)
M		src/knonefilter.h (21 lines)
M		src/knonefilter.cpp (21 lines)
M		src/krcc.h (18 lines)
M		src/krcc.cpp (20 lines)
M		src/ktar.h (18 lines)
M		src/ktar.cpp (20 lines)
M		src/kxzfilter.h (19 lines)
M		src/kxzfilter.cpp (21 lines)
M		src/kzip.h (16 lines)
M		src/kzip.cpp (20 lines)
M		src/kzipfileentry.h (16 lines)
M		tests/k7ziptest.cpp (16 lines)
M		tests/kartest.cpp (17 lines)
M		tests/krcctest.cpp (14 lines)
M		tests/ktartest.cpp (14 lines)
M		tests/kziptest.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	74862	a331ffa		Feb 2 2020, 4:46 PM	★	★
Diff 2	75213	a7cfd80	R243:8c40c6f028b3956f43b910aedbd1345c1dffd6fc	Feb 8 2020, 8:45 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
c1fb9ccb8cce	4bdfdf87cbd1	9a763ac8e7c0	Andreas Cord-Landwehr	Add license files compatible with REUSE.software	Feb 2 2020, 4:42 PM
9a763ac8e7c0	69d2395d9236	a331ffacfec1	Andreas Cord-Landwehr	Convert license statements to SPDX headers	Feb 2 2020, 4:42 PM

KArchive: Convert license statements to SPDX headersClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 75213

LICENSES/BSD-2-Clause.txt

LICENSES/LGPL-2.0-only.txt

LICENSES/LGPL-2.0-or-later.txt

LICENSES/LGPL-3.0-only.txt

LICENSES/LicenseRef-KDE-Accepted-LGPL.txt

autotests/deprecatedtest.cpp

autotests/karchivetest.h

autotests/karchivetest.cpp

autotests/kcompressiondevicetest.h

autotests/kcompressiondevicetest.cpp

autotests/kfiltertest.h

autotests/kfiltertest.cpp

autotests/klimitediodevicetest.h

autotests/klimitediodevicetest.cpp

examples/bzip2gzip/main.cpp

examples/helloworld/main.cpp

examples/tarlocalfiles/main.cpp

examples/unzipper/main.cpp

src/k7zip.h

src/k7zip.cpp

src/kar.h

src/kar.cpp

src/karchive.h

src/karchive.cpp

src/karchive_p.h

src/karchivedirectory.h

src/karchiveentry.h

src/karchivefile.h

src/kbzip2filter.h

src/kbzip2filter.cpp

src/kcompressiondevice.h

src/kcompressiondevice.cpp

src/kcompressiondevice_p.h

src/kfilterbase.h

src/kfilterbase.cpp

src/kfilterdev.h

src/kfilterdev.cpp

src/kgzipfilter.h

src/kgzipfilter.cpp

src/klimitediodevice.cpp

src/klimitediodevice_p.h

src/knonefilter.h

src/knonefilter.cpp

src/krcc.h

src/krcc.cpp

src/ktar.h

src/ktar.cpp

src/kxzfilter.h

src/kxzfilter.cpp

src/kzip.h

src/kzip.cpp

src/kzipfileentry.h

tests/k7ziptest.cpp

tests/kartest.cpp

tests/krcctest.cpp

tests/ktartest.cpp

tests/kziptest.cpp

KArchive: Convert license statements to SPDX headers
ClosedPublic
Actions

Revision Contents
Changeset List