KItemModels: Convert license headers to SPDX markers
ClosedPublic
Actions

Authored by cordlandwehr on Feb 2 2020, 4:17 PM.

Details

Reviewers

dfaure
krop

Maniphest Tasks

T11550: Add SPDX License markers

Commits

R275:be32ab6c49f9: KItemModels: Convert license headers to SPDX markers

Summary

Convert license headers to SPDX markers and add REUSE.software
compliant licesne files. This update also includes several copyright holder
clarifications for contracted contributors, where only implicitly the
copyright for the authors was stated inside the copyright statement of
the company.

Diff Detail

Repository

R275 KItemModels

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cordlandwehr created this revision.Feb 2 2020, 4:17 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 2 2020, 4:17 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

cordlandwehr requested review of this revision.Feb 2 2020, 4:17 PM

Harbormaster completed remote builds in B21967: Diff 74861.Feb 2 2020, 4:17 PM

cordlandwehr added a task: T11550: Add SPDX License markers.Feb 2 2020, 4:18 PM

Can you have a look at the KDAB license statement changes? Specifically the point that now the copyright statement explicitly states the copyright for both the author and the company, where previously the author's copyright was only implicitly stated.

same remark as for D27106. Check if FileContributor is more appropriate.

krop added inline comments.Feb 6 2020, 9:32 PM

autotests/proxymodeltestsuite/modeltest.h
4	redirects to https://www.qt.io/terms-conditions/ nowadays

cordlandwehr mentioned this in T11550: Add SPDX License markers.Feb 8 2020, 8:46 AM

cordlandwehr retitled this revision from Convert license headers to SPDX markers to KItemModels: Convert license headers to SPDX markers.Feb 8 2020, 10:35 AM

Incorporate review findings

Use FileContributor tag for stating authors without copyright claim
Resolving Qt legal redirect
Unify comment style for copyright statements

Harbormaster completed remote builds in B22421: Diff 75580.Feb 13 2020, 8:43 AM

cordlandwehr marked an inline comment as done.Feb 13 2020, 8:44 AM

krop added inline comments.Feb 13 2020, 8:51 AM

autotests/proxymodeltestsuite/modeltest.h
4	Unneeded extra space added for a couple files "and /or" vs "and/or"

Please push after fixing the remaining issues

This revision is now accepted and ready to land.Feb 13 2020, 8:52 AM

Remove unneeded whitespace

Harbormaster completed remote builds in B22424: Diff 75587.Feb 13 2020, 10:35 AM

cordlandwehr marked an inline comment as done.Feb 13 2020, 10:35 AM

Closed by commit R275:be32ab6c49f9: KItemModels: Convert license headers to SPDX markers (authored by cordlandwehr). · Explain WhyFeb 13 2020, 10:35 AM

This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 113 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

		Path
A	M	LICENSES/LGPL-2.0-or-later.txt (446 lines)
A	M	LICENSES/LGPL-2.1-only.txt (467 lines)
A	M	LICENSES/LGPL-2.1-or-later.txt (468 lines)
M		autotests/bihash/benchmarks.cpp (22 lines)
M		autotests/bihash/functionalitytest.cpp (22 lines)
M		autotests/kcolumnheadersmodeltest.cpp (19 lines)
M		autotests/kconcatenaterows_qml.cpp (19 lines)
M		autotests/kdescendantsproxymodel_smoketest.cpp (22 lines)
M		autotests/kdescendantsproxymodeltest.cpp (19 lines)
M		autotests/kextracolumnsproxymodeltest.cpp (21 lines)
M		autotests/klinkitemselectionmodeltest.h (20 lines)
M		autotests/klinkitemselectionmodeltest.cpp (19 lines)
M		autotests/kmodelindexproxymappertest.cpp (21 lines)
M		autotests/knumbermodeltest.cpp (19 lines)
M		autotests/krearrangecolumnsproxymodeltest.cpp (21 lines)
M		autotests/krecursivefilterproxymodeltest.cpp (22 lines)
M		autotests/kselectionproxymodel_smoketest.cpp (19 lines)
M		autotests/kselectionproxymodeltest.cpp (25 lines)
M		autotests/kselectionproxymodeltestsuite.h (19 lines)
M		autotests/kselectionproxymodeltestsuite.cpp (17 lines)
M		autotests/proxymodeltestsuite/dynamictreemodel.h (19 lines)
M		autotests/proxymodeltestsuite/dynamictreemodel.cpp (19 lines)
M		autotests/proxymodeltestsuite/dynamictreewidget.h (19 lines)
M		autotests/proxymodeltestsuite/dynamictreewidget.cpp (19 lines)
M		autotests/proxymodeltestsuite/eventloggerregister.h (22 lines)
M		autotests/proxymodeltestsuite/eventloggerregister.cpp (20 lines)
M		autotests/proxymodeltestsuite/indexfinder.h (17 lines)
M		autotests/proxymodeltestsuite/modelcommander.h (19 lines)
M		autotests/proxymodeltestsuite/modelcommander.cpp (19 lines)
M		autotests/proxymodeltestsuite/modeldumper.h (22 lines)
M		autotests/proxymodeltestsuite/modeldumper.cpp (22 lines)
M		autotests/proxymodeltestsuite/modeleventlogger.h (22 lines)
M		autotests/proxymodeltestsuite/modeleventlogger.cpp (22 lines)
M		autotests/proxymodeltestsuite/modelselector.h (19 lines)
M		autotests/proxymodeltestsuite/modelselector.cpp (17 lines)
M		autotests/proxymodeltestsuite/modelspy.h (19 lines)
M		autotests/proxymodeltestsuite/modelspy.cpp (19 lines)
M		autotests/proxymodeltestsuite/modeltest.h (24 lines)
M		autotests/proxymodeltestsuite/modeltest.cpp (25 lines)
M		autotests/proxymodeltestsuite/persistentchangelist.h (19 lines)
M		autotests/proxymodeltestsuite/proxymodeltest.h (19 lines)
M		autotests/proxymodeltestsuite/proxymodeltest.cpp (19 lines)
M		autotests/test_model_helpers.h (19 lines)
M		src/core/kbihash_p.h (22 lines)
M		src/core/kbreadcrumbselectionmodel.h (22 lines)
M		src/core/kbreadcrumbselectionmodel.cpp (22 lines)
M		src/core/kcheckableproxymodel.h (20 lines)
M		src/core/kcheckableproxymodel.cpp (19 lines)
M		src/core/kcolumnheadersmodel.h (17 lines)
M		src/core/kcolumnheadersmodel.cpp (19 lines)
M		src/core/kconcatenaterowsproxymodel.h (21 lines)
M		src/core/kconcatenaterowsproxymodel.cpp (21 lines)
M		src/core/kdescendantsproxymodel.h (19 lines)
M		src/core/kdescendantsproxymodel.cpp (24 lines)
M		src/core/kextracolumnsproxymodel.h (21 lines)
M		src/core/kextracolumnsproxymodel.cpp (21 lines)
M		src/core/klinkitemselectionmodel.h (26 lines)
M		src/core/klinkitemselectionmodel.cpp (26 lines)
M		src/core/kmodelindexproxymapper.h (26 lines)
M		src/core/kmodelindexproxymapper.cpp (26 lines)
M		src/core/knumbermodel.h (19 lines)
M		src/core/knumbermodel.cpp (19 lines)
M		src/core/krearrangecolumnsproxymodel.h (21 lines)
M		src/core/krearrangecolumnsproxymodel.cpp (21 lines)
M		src/core/krecursivefilterproxymodel.h (19 lines)
M		src/core/krecursivefilterproxymodel.cpp (19 lines)
M		src/core/kselectionproxymodel.h (19 lines)
M		src/core/kselectionproxymodel.cpp (23 lines)
M		src/core/kvoidpointerfactory_p.h (20 lines)
M		src/qml/kconcatenaterowsproxymodel_qml.h (19 lines)
M		src/qml/kconcatenaterowsproxymodel_qml.cpp (17 lines)
M		src/qml/plugin.h (17 lines)
M		src/qml/plugin.cpp (17 lines)
M		tests/proxymodeltestapp/breadcrumbdirectionwidget.h (20 lines)
M		tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp (20 lines)
M		tests/proxymodeltestapp/breadcrumbnavigationwidget.h (22 lines)
M		tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp (22 lines)
M		tests/proxymodeltestapp/breadcrumbswidget.h (22 lines)
M		tests/proxymodeltestapp/breadcrumbswidget.cpp (22 lines)
M		tests/proxymodeltestapp/checkablewidget.h (20 lines)
M		tests/proxymodeltestapp/checkablewidget.cpp (20 lines)
M		tests/proxymodeltestapp/descendantpmwidget.h (25 lines)
M		tests/proxymodeltestapp/descendantpmwidget.cpp (25 lines)
M		tests/proxymodeltestapp/kidentityproxymodelwidget.h (20 lines)
M		tests/proxymodeltestapp/kidentityproxymodelwidget.cpp (20 lines)
M		tests/proxymodeltestapp/kreparentingproxymodel.h (19 lines)
M		tests/proxymodeltestapp/kreparentingproxymodel.cpp (19 lines)
M		tests/proxymodeltestapp/lessthanwidget.h (25 lines)
M		tests/proxymodeltestapp/lessthanwidget.cpp (25 lines)
M		tests/proxymodeltestapp/main.cpp (21 lines)
M		tests/proxymodeltestapp/mainwindow.h (25 lines)
M		tests/proxymodeltestapp/mainwindow.cpp (25 lines)
M		tests/proxymodeltestapp/matchcheckingwidget.h (19 lines)
M		tests/proxymodeltestapp/matchcheckingwidget.cpp (19 lines)
M		tests/proxymodeltestapp/modelcommanderwidget.h (19 lines)
M		tests/proxymodeltestapp/modelcommanderwidget.cpp (19 lines)
M		tests/proxymodeltestapp/proxyitemselectionwidget.h (20 lines)
M		tests/proxymodeltestapp/proxyitemselectionwidget.cpp (22 lines)
M		tests/proxymodeltestapp/proxymodeltestwidget.h (25 lines)
M		tests/proxymodeltestapp/proxymodeltestwidget.cpp (25 lines)
M		tests/proxymodeltestapp/recursivefilterpmwidget.h (25 lines)
M		tests/proxymodeltestapp/recursivefilterpmwidget.cpp (25 lines)
M		tests/proxymodeltestapp/reparentingpmwidget.h (25 lines)
M		tests/proxymodeltestapp/reparentingpmwidget.cpp (25 lines)
M		tests/proxymodeltestapp/scriptablereparentingwidget.h (17 lines)
M		tests/proxymodeltestapp/scriptablereparentingwidget.cpp (19 lines)
M		tests/proxymodeltestapp/selection.qml (17 lines)
M		tests/proxymodeltestapp/selectioninqmlwidget.h (25 lines)
M		tests/proxymodeltestapp/selectioninqmlwidget.cpp (25 lines)
M		tests/proxymodeltestapp/selectionpmwidget.h (25 lines)
M		tests/proxymodeltestapp/selectionpmwidget.cpp (25 lines)
M		tests/proxymodeltestapp/statesaverwidget.h (22 lines)
M		tests/proxymodeltestapp/statesaverwidget.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	74861	e54aafc		Feb 2 2020, 4:17 PM	★	★
Diff 2	75580	e54aafc	Incorporate review findings	Feb 13 2020, 8:43 AM	★	★
Diff 3	75587	e54aafc	Remove unneeded whitespace	Feb 13 2020, 10:35 AM	★	★
Diff 4	75588	424c2e9	R275:be32ab6c49f9de472c469270c3c53686bed8849e	Feb 13 2020, 10:35 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a492666bc214	154a11f5c00a	a524d722c426	Andreas Cord-Landwehr	Remove unneeded whitespace	Feb 13 2020, 10:34 AM
a524d722c426	1b428520ee2e	38b77a71813f	Andreas Cord-Landwehr	Unify comment style for copyright statements	Feb 13 2020, 8:42 AM
38b77a71813f	75eb357d635d	1b8c9d939d85	Andreas Cord-Landwehr	Resolving Qt legal redirect	Feb 13 2020, 8:35 AM
1b8c9d939d85	4f2f186a7c25	e207abfac8ba	Andreas Cord-Landwehr	Use FileContributor tag for stating authors without copyright claim	Feb 13 2020, 8:34 AM
e207abfac8ba	d7c0bd011962	505981660531	Andreas Cord-Landwehr	Convert license headers to SPDX markers (Show More…)	Feb 2 2020, 4:13 PM
505981660531	c785ba2bb759	e54aafc04575	Andreas Cord-Landwehr	Convert license headers to SPDX markers	Feb 1 2020, 6:44 PM

KItemModels: Convert license headers to SPDX markersClosedPublicActions

Details

Diff Detail

Large Diff

Revision ContentsChangeset List

Diff 75588

LICENSES/LGPL-2.0-or-later.txt

LICENSES/LGPL-2.1-only.txt

LICENSES/LGPL-2.1-or-later.txt

autotests/bihash/benchmarks.cpp

autotests/bihash/functionalitytest.cpp

autotests/kcolumnheadersmodeltest.cpp

autotests/kconcatenaterows_qml.cpp

autotests/kdescendantsproxymodel_smoketest.cpp

autotests/kdescendantsproxymodeltest.cpp

autotests/kextracolumnsproxymodeltest.cpp

autotests/klinkitemselectionmodeltest.h

autotests/klinkitemselectionmodeltest.cpp

autotests/kmodelindexproxymappertest.cpp

autotests/knumbermodeltest.cpp

autotests/krearrangecolumnsproxymodeltest.cpp

autotests/krecursivefilterproxymodeltest.cpp

autotests/kselectionproxymodel_smoketest.cpp

autotests/kselectionproxymodeltest.cpp

autotests/kselectionproxymodeltestsuite.h

autotests/kselectionproxymodeltestsuite.cpp

autotests/proxymodeltestsuite/dynamictreemodel.h

autotests/proxymodeltestsuite/dynamictreemodel.cpp

autotests/proxymodeltestsuite/dynamictreewidget.h

autotests/proxymodeltestsuite/dynamictreewidget.cpp

autotests/proxymodeltestsuite/eventloggerregister.h

autotests/proxymodeltestsuite/eventloggerregister.cpp

autotests/proxymodeltestsuite/indexfinder.h

autotests/proxymodeltestsuite/modelcommander.h

autotests/proxymodeltestsuite/modelcommander.cpp

autotests/proxymodeltestsuite/modeldumper.h

autotests/proxymodeltestsuite/modeldumper.cpp

autotests/proxymodeltestsuite/modeleventlogger.h

autotests/proxymodeltestsuite/modeleventlogger.cpp

autotests/proxymodeltestsuite/modelselector.h

autotests/proxymodeltestsuite/modelselector.cpp

autotests/proxymodeltestsuite/modelspy.h

autotests/proxymodeltestsuite/modelspy.cpp

autotests/proxymodeltestsuite/modeltest.h

autotests/proxymodeltestsuite/modeltest.cpp

autotests/proxymodeltestsuite/persistentchangelist.h

autotests/proxymodeltestsuite/proxymodeltest.h

autotests/proxymodeltestsuite/proxymodeltest.cpp

autotests/test_model_helpers.h

src/core/kbihash_p.h

src/core/kbreadcrumbselectionmodel.h

src/core/kbreadcrumbselectionmodel.cpp

src/core/kcheckableproxymodel.h

src/core/kcheckableproxymodel.cpp

src/core/kcolumnheadersmodel.h

src/core/kcolumnheadersmodel.cpp

src/core/kconcatenaterowsproxymodel.h

src/core/kconcatenaterowsproxymodel.cpp

src/core/kdescendantsproxymodel.h

src/core/kdescendantsproxymodel.cpp

src/core/kextracolumnsproxymodel.h

src/core/kextracolumnsproxymodel.cpp

src/core/klinkitemselectionmodel.h

src/core/klinkitemselectionmodel.cpp

src/core/kmodelindexproxymapper.h

src/core/kmodelindexproxymapper.cpp

src/core/knumbermodel.h

src/core/knumbermodel.cpp

src/core/krearrangecolumnsproxymodel.h

src/core/krearrangecolumnsproxymodel.cpp

src/core/krecursivefilterproxymodel.h

src/core/krecursivefilterproxymodel.cpp

src/core/kselectionproxymodel.h

src/core/kselectionproxymodel.cpp

src/core/kvoidpointerfactory_p.h

src/qml/kconcatenaterowsproxymodel_qml.h

src/qml/kconcatenaterowsproxymodel_qml.cpp

src/qml/plugin.h

src/qml/plugin.cpp

tests/proxymodeltestapp/breadcrumbdirectionwidget.h

KItemModels: Convert license headers to SPDX markers
ClosedPublic
Actions

Revision Contents
Changeset List