[Activity Manager] Hide "Create Activity" and "Delete Activity" if not authorized
ClosedPublic
Actions

Authored by broulik on Sep 8 2016, 9:26 AM.

Details

Reviewers

davidedmundson
ivan

Group Reviewers

Plasma

Commits

R119:83335d5a85e2: [Activity Manager] Hide "Create Activity" and "Delete Activity" if not…

Summary

When the "plasma-desktop/add_activities" is set, adding and removing activities is prevented by the activity manager but we kept showing then non-functional buttons in the UI.

Test Plan

Added the following to kdeglobals

[KDE Action Restrictions]
plasma-desktop/add_activities=true

Opened activity manager. "Create Activity" was gone as well as the delete button on stopped activities. Removed it again and it still worked.

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik updated this revision to Diff 6533.Sep 8 2016, 9:26 AM

broulik retitled this revision from to [Activity Manager] Hide "Create Activity" and "Delete Activity" if not authorized.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added reviewers: Plasma, ivan.

broulik set the repository for this revision to R119 Plasma Desktop.

Restricted Application added a project: Plasma. · View Herald TranscriptSep 8 2016, 9:26 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson accepted this revision.Sep 8 2016, 9:36 AM

davidedmundson added a reviewer: davidedmundson.

This revision is now accepted and ready to land.Sep 8 2016, 9:36 AM

Closed by commit R119:83335d5a85e2: [Activity Manager] Hide "Create Activity" and "Delete Activity" if not… (authored by broulik). · Explain WhySep 9 2016, 7:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			desktoppackage/contents/activitymanager/ActivityManager.qml (1 line)
M			desktoppackage/contents/activitymanager/StoppedActivityItem.qml (1 line)
M			kcms/activities/imports/CMakeLists.txt (3 lines)
M			kcms/activities/imports/activitysettings.h (8 lines)
M			kcms/activities/imports/activitysettings.cpp (7 lines)