Remove header top margin from private ScrollView
ClosedPublic

Authored by ahiemstra on Jan 30 2020, 12:13 PM.

Details

Summary

With the scrollbars taking up actual width, the top margin of the vertical
scrollbar being set to the list header looks really awkward and buggy. This
removes the top margin, making the scrollbar take the entire flickable's
height. This change also applies to overlay scrollbars as I consider the
margin behaviour to be incorrect even for those, as the top margin will
change based on the header height, which causes the scrollbar to resize
when the header shrinks.

Test Plan

Before:

After:

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Jan 30 2020, 12:13 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJan 30 2020, 12:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Jan 30 2020, 12:13 PM
ahiemstra edited the test plan for this revision. (Show Details)Jan 30 2020, 12:17 PM
ngraham accepted this revision.Jan 30 2020, 2:33 PM
This revision is now accepted and ready to land.Jan 30 2020, 2:33 PM
mart accepted this revision.Jan 31 2020, 2:18 PM
This revision was automatically updated to reflect the committed changes.