Hide irrevelevant default button, code clean and future proofing
ClosedPublic

Authored by meven on Wed, Jan 22, 6:25 PM.

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Wed, Jan 22, 6:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Jan 22, 6:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Wed, Jan 22, 6:25 PM
ngraham accepted this revision.Wed, Jan 22, 8:05 PM
This revision is now accepted and ready to land.Wed, Jan 22, 8:05 PM
This revision was automatically updated to reflect the committed changes.

Fails to build:

https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console

00:42:51 /workspace/build/src/usermanager.cpp: In constructor ‘UserManager::UserManager(QWidget*, const QVariantList&)’:
00:42:51 /workspace/build/src/usermanager.cpp:68:70: error: no matching function for call to ‘UserManager::connect(AccountInfo*&, void (AccountInfo::*)(bool), UserManager*, <unresolved overloaded function type>)’
00:42:51 connect(m_widget, &AccountInfo::changed, this, &KCModule::changed);
00:42:51 ^

Fails to build:

https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console

00:42:51 /workspace/build/src/usermanager.cpp: In constructor ‘UserManager::UserManager(QWidget*, const QVariantList&)’:
00:42:51 /workspace/build/src/usermanager.cpp:68:70: error: no matching function for call to ‘UserManager::connect(AccountInfo*&, void (AccountInfo::*)(bool), UserManager*, <unresolved overloaded function type>)’
00:42:51 connect(m_widget, &AccountInfo::changed, this, &KCModule::changed);
00:42:51 ^

Thanks @rikmills

I don't get why it does not compile.
I don't reproduce locally :/

Tentative fix : https://phabricator.kde.org/D26893