Add and use OsmPlacemarkData::findTag(const QString& key)
ClosedPublic
Actions

Authored by kossebau on Sep 6 2016, 3:47 PM.

Details

Reviewers

sanjibanb
nienhueser
shentey

Group Reviewers

Marble

Commits

R34:6a5e0d810d43: Add and use OsmPlacemarkData::findTag(const QString& key)

Summary

Some code getting data from OsmPlacemarkData instances currently
does a double-lookup with data.containsTagKey(x) & data.tagValue(x).
As OsmPlacemarkData already exposes begin and end iterators for the
tags, adding a findTag(const QString &key) to allow single-lookup
of a tag on conditional access to its value seems matching.

Resulting code trades readability (IMHO) for speed, but for a library this
option seems to make sense.

Diff Detail

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau updated this revision to Diff 6492.Sep 6 2016, 3:47 PM

kossebau retitled this revision from to Add and use OsmPlacemarkData::findTag(const QString& key).

kossebau updated this object.

kossebau added reviewers: Marble, shentey, nienhueser, sanjibanb.

Looks good to me. I'm used to that pattern, so to me it doesn't degrade readability too much.

This revision is now accepted and ready to land.Sep 6 2016, 6:19 PM

Closed by commit R34:6a5e0d810d43: Add and use OsmPlacemarkData::findTag(const QString& key) (authored by kossebau). · Explain WhySep 6 2016, 7:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/marble/StyleBuilder.cpp (42 lines)
M			src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp (37 lines)
M			src/lib/marble/osm/OsmPlacemarkData.h (6 lines)
M			src/lib/marble/osm/OsmPlacemarkData.cpp (5 lines)
M			src/plugins/runner/json/JsonParser.cpp (6 lines)
M			src/plugins/runner/osm/OsmNode.cpp (5 lines)
M			src/plugins/runner/osm/OsmRelation.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6492	981a59a		Sep 6 2016, 3:46 PM	★	★
Diff 2	6498	c04efe5	rMARBLE6a5e0d810d43dab354784f2dc877e8243a395bf0	Sep 6 2016, 7:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
1d58d1610b73	3475d1bb14af	981a59aa12df	Friedrich W. H. Kossebau	Add and use OsmPlacemarkData::findTag(const QString& key) (Show More…)	Sep 6 2016, 3:38 PM