Install private libs in a private subfolder of /usr/lib/$triplet
Needs ReviewPublic

Authored by aureliencouderc on Jan 21 2020, 8:15 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Dear upstream Maintainer,

while updating the Artikulate package from Debian I noticed that it installs some private libraries in the public libraries folder /usr/lib/$triplet.

This patch fixes the issue by installing Artikulate’s private libraries into an artikulate subfolder, and referencing it in the INSTALL_RPATH where required.

Test Plan
  • ldd ./artikulate and check that all libraries link successfully
  • launch artikulate and check that it starts correctly
  • ldd ./artikulate_editor and check that all libraries link successfully
  • launch artikulate_editor and check that it starts correctly

Diff Detail

Repository
R72 Artikulate
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 21 2020, 8:15 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
aureliencouderc requested review of this revision.Jan 21 2020, 8:15 PM

Note: the changes were inspired by Elisa where they did a similar move a couple of months ago.

aureliencouderc edited the test plan for this revision. (Show Details)Jan 21 2020, 8:24 PM
aacid added a subscriber: aacid.Jan 28 2020, 11:46 PM

What's really the need for this?

Seems to make the code much more complex with lots of Apple and Win32 checks "for nothing"?

I agree with Albert here, I would like to understand the real need for this.
Moreover, if we really have to handle this differently for Mac and Windows, I would prefer to have a general method introduced into extra-cmake-modules in order to keep the application build system config easier to understand. Using private libraries actually is not such a rare use case, so we should use a generic approach for solving it.