[Notifications] Send reply text as targeted signal
ClosedPublic

Authored by broulik on Tue, Jan 21, 9:34 AM.

Details

Summary

Avoids waking up non-interested parties.

Test Plan

5.18
while it is an API change, it was only released in the Beta yet

  • Tried with Telgram patch, reply text field still worked

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Tue, Jan 21, 9:34 AM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Jan 21, 9:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Tue, Jan 21, 9:34 AM
davidedmundson accepted this revision.Tue, Jan 21, 11:54 AM
This revision is now accepted and ready to land.Tue, Jan 21, 11:54 AM
broulik updated this revision to Diff 74006.Tue, Jan 21, 12:04 PM
  • No fallback, createTargetedSignal without a service seems to behave like the non-targeted version
davidedmundson accepted this revision.Tue, Jan 21, 12:06 PM
This revision was automatically updated to reflect the committed changes.