Remove pointless code
ClosedPublic

Authored by davidedmundson on Sep 6 2016, 8:39 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:cb477299c8a4: Remove outdated code
Summary

It doesn't make sense to emit a signal in someone elses layout object

  1. only the containment.Layout.preferedSize is ever used
  2. and the only user (panel.qml) is constantly bound anwyay.

I assume it was an attempted workaround for the bug in the panelview
length cleanup that I did ages ago.

Test Plan

Resized all the things in plasma configure mode.
No changes.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Remove pointless code.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 6 2016, 8:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Sep 6 2016, 9:14 AM

removing it makes sense to me
as that code is weird, here's my research on its history:

looking at why it was inserted:
commit 0cf01e3d
"This patch fixes this warning and also some rendering issues in the panel's settings dialog, where the buttons would have different sizes when laid out vertically."

also in part
commit fa827016
"don't auto resize when the panel controller is open"

for fa827016, this blind emitting of signals doesn't apply anymore, so the patch shoud good to go in

mart accepted this revision.Sep 6 2016, 9:14 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Sep 6 2016, 9:14 AM

Good research, thanks.
(I think that makes it my fault for removing half of it, and not the other half)

This revision was automatically updated to reflect the committed changes.