Differential D26714

KCM/Component Revamp FileManager UI
ClosedPublic
Actions

Authored by meven on Jan 16 2020, 6:03 PM.

Details

Reviewers
ervin
ngraham
Group Reviewers
Plasma
Maniphest Tasks
T12551: Revamp KCM/Component chooser
Commits
R119:2e54c4e748ba: KCM/Component Revamp FileManager UI
Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
filemanager-settings
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21407
Build 21425: arc lint + arc unit
meven created this revision.Jan 16 2020, 6:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2020, 6:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Jan 16 2020, 6:03 PM
ngraham added a comment.Jan 17 2020, 4:03 AM

Selecting the "Other..." option for this one takes me to the filetype editor for inode/directory instead of the app chooser as in the other patches. Is that intentional?

meven planned changes to this revision.Jan 17 2020, 8:04 AM
In D26714#595786, @ngraham wrote:

Selecting the "Other..." option for this one takes me to the filetype editor for inode/directory instead of the app chooser as in the other patches. Is that intentional?

It is.
But I was thinking about using the app chooser directly for consistency.

meven updated this revision to Diff 73746.Jan 17 2020, 8:27 AM

Use KOpenWithDialog instead of keditfiletype5 to select the filemanager + small fix

meven added inline comments.Jan 17 2020, 10:18 AM
kcms/componentchooser/componentchooserfilemanager.cpp
117

wrong comment

ngraham accepted this revision.Jan 17 2020, 1:29 PM
This revision is now accepted and ready to land.Jan 17 2020, 1:29 PM
ervin accepted this revision.Jan 20 2020, 1:50 PM
meven updated this revision to Diff 73946.Jan 20 2020, 3:00 PM

Correct comment

ervin accepted this revision.Jan 20 2020, 3:22 PM
meven updated this revision to Diff 73951.Jan 20 2020, 3:30 PM

Fix: Save the newly saved selected filemanager in m_currentIndex

ervin accepted this revision.Jan 20 2020, 3:51 PM
meven updated this revision to Diff 73962.Jan 20 2020, 4:09 PM

Add copyright mention, add icon for added terminal emulator

Closed by commit R119:2e54c4e748ba: KCM/Component Revamp FileManager UI (authored by meven). · Explain WhyJan 20 2020, 4:12 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 73962

View Options

kcms/componentchooser/componentchooserfilemanager.cpp

Loading...