Differential D2671

Reduce duplicated code and document very difficult to parse code.
ClosedPublic
Actions

Authored by davidedmundson on Sep 6 2016, 8:39 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Test Plan

Panel still loads, is just code moving, so should be no changes.

Diff Detail

Repository
R119 Plasma Desktop
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 6464.Sep 6 2016, 8:39 AM
davidedmundson retitled this revision from to Reduce duplicated code and document very difficult to parse code..
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 6 2016, 8:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Sep 6 2016, 8:41 AM
broulik added inline comments.
desktoppackage/contents/views/Panel.qml
97

why real? You cannot (should not) have half pixels

davidedmundson added inline comments.Sep 6 2016, 8:44 AM
desktoppackage/contents/views/Panel.qml
97

There's a Math.round in the usage below, and FrameMargins can also be real, so it's still needed there.

mart accepted this revision.Sep 6 2016, 9:04 AM
mart added a reviewer: mart.
mart added a subscriber: mart.
mart added inline comments.
desktoppackage/contents/views/Panel.qml
97

given that we round the value everywhere actually used, either is fine

This revision is now accepted and ready to land.Sep 6 2016, 9:04 AM

Revision Contents
Changeset List

Diff 6464

View Options

desktoppackage/contents/views/Panel.qml

Loading...