Differential D26705

KCM/Component Revamp Terminal Emulator UI
ClosedPublic
Actions

Authored by meven on Jan 16 2020, 1:40 PM.

Details

Reviewers
ervin
ngraham
Group Reviewers
Plasma
Maniphest Tasks
T12551: Revamp KCM/Component chooser
Commits
R119:4a0ba9e02697: KCM/Component Revamp Terminal Emulator UI
Summary

Revamp UI, to use a simple combobox

  • Other... choice allows to select any programe
  • Keep konsole as default
  • changed & default works
  • List in the combobox known TerminalEmulator installed
Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
terminal-config
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21263
Build 21281: arc lint + arc unit
meven created this revision.Jan 16 2020, 1:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2020, 1:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Jan 16 2020, 1:40 PM
meven edited the test plan for this revision. (Show Details)Jan 16 2020, 1:41 PM
meven edited the summary of this revision. (Show Details)
ngraham accepted this revision.Jan 16 2020, 4:05 PM
ngraham added inline comments.
kcms/componentchooser/componentchooserterminal.cpp
76

NoDisplay == false seems slightly more readable than NoDisplay != true

This revision is now accepted and ready to land.Jan 16 2020, 4:05 PM
meven updated this revision to Diff 73718.Jan 16 2020, 4:22 PM
meven marked an inline comment as done.
meven edited the test plan for this revision. (Show Details)

NoDisplay == false instead of NoDisplay != true

meven added inline comments.Jan 17 2020, 8:33 AM
kcms/componentchooser/componentchooserterminal.cpp
138 ↗(On Diff #73718)

Remove

143 ↗(On Diff #73718)

Remove

meven marked 2 inline comments as done.Jan 17 2020, 10:00 AM
meven updated this revision to Diff 73750.Jan 17 2020, 10:00 AM

Clean two bad lines

meven added inline comments.Jan 17 2020, 10:39 AM
kcms/componentchooser/componentchooserterminal.cpp
47

remove

ervin added inline comments.Jan 20 2020, 1:47 PM
kcms/componentchooser/componentchooserterminal.cpp
46

Curly brace should be on its own line

49

Missing space after -

meven updated this revision to Diff 73949.Jan 20 2020, 3:25 PM
meven marked 3 inline comments as done.

Fix formatting, remove a bad Q_UNUSED

meven updated this revision to Diff 73950.Jan 20 2020, 3:28 PM

Fix: Save the newly saved selected terminal emulator in m_currentIndex

ervin accepted this revision.Jan 20 2020, 3:51 PM
Closed by commit R119:4a0ba9e02697: KCM/Component Revamp Terminal Emulator UI (authored by meven). · Explain WhyJan 20 2020, 4:05 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 73750

View Options

kcms/componentchooser/componentchooserterminal.cpp

Loading...