Differential D26700

[scenes/opengl] Merge window classes
ClosedPublic
Actions

Authored by zzag on Jan 15 2020, 9:28 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:b8368fdf6f0a: [scenes/opengl] Merge window classes
Summary

Legacy OpenGL 1 compositing backend had been dropped quite a while ago
so some of OpenGL scene classes can be merged back.

Test Plan

Compiles, windows are rendered as before.

Diff Detail

Repository
R108 KWin
Branch
refactor-out-opengl-window
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 21209
Build 21227: arc lint + arc unit
zzag created this revision.Jan 15 2020, 9:28 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 15 2020, 9:28 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 15 2020, 9:28 PM
zzag updated this revision to Diff 73664.Jan 15 2020, 9:33 PM

Update a comment

zzag updated this revision to Diff 73665.Jan 15 2020, 9:35 PM

Remove a class forward declaration.

davidedmundson accepted this revision.Jan 15 2020, 10:42 PM
davidedmundson added a subscriber: davidedmundson.

I like red patches.

This revision is now accepted and ready to land.Jan 15 2020, 10:42 PM
Closed by commit R108:b8368fdf6f0a: [scenes/opengl] Merge window classes (authored by zzag). · Explain WhyJan 15 2020, 11:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73665

View Options

plugins/scenes/opengl/scene_opengl.h

Loading...
View Options

plugins/scenes/opengl/scene_opengl.cpp

Loading...