Differential D26686

Remove scrollbar related workarounds from list delegates
ClosedPublic
Actions

Authored by ahiemstra on Jan 15 2020, 9:46 AM.

Details

Reviewers
ngraham
mart
Group Reviewers
Plasma
Commits
R858:9dfb38179ac5: Remove scrollbar related workarounds from list delegates
Summary

Now that we no longer overlap scrollbars, we can get rid of all the workarounds
needed to make the overlapping scrollbars work. This gets rid of the workarounds
in ItemDelegate and related items.

Test Plan

Before: Too much padding on the right side

After: Correct padding

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Jan 15 2020, 9:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 15 2020, 9:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Jan 15 2020, 9:46 AM
ahiemstra edited the test plan for this revision. (Show Details)Jan 15 2020, 9:48 AM
ngraham added a subscriber: ngraham.Jan 15 2020, 4:59 PM

Will we still need the LayoutMirroring.enabled ? logic to account for when using an RTL language where the scrollbar is on the left side?

ahiemstra added a comment.EditedJan 16 2020, 10:57 AM

The logic for placing the scrollbar is in ScrollView already. Since the delegate no longer needs special padding, this changes the padding to the same value for left or right. We could change the padding depending on where the scrollbar is, but I don't think that would be an improvement.

ngraham accepted this revision.Jan 16 2020, 4:37 PM
This revision is now accepted and ready to land.Jan 16 2020, 4:37 PM
mart accepted this revision.Jan 27 2020, 11:36 AM
Closed by commit R858:9dfb38179ac5: Remove scrollbar related workarounds from list delegates (authored by ahiemstra). · Explain WhyJan 27 2020, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 74442