Fix panelView updateEnabledBorders being skipped
ClosedPublic
Actions

Authored by davidedmundson on Sep 6 2016, 8:34 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

Sometimes the left/right panel edge shadows don't get drawn.
A resize doesn't always call positionPanel so it never gets updated on all
size changes.

Putting it in the event handlers rather than in the setting, means it
will never be missed again.

Test Plan

Set panel to fill width
Resizing now shows correct corner

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Fix panelView updateEnabledBorders being skipped.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart accepted this revision.Sep 6 2016, 8:59 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Sep 6 2016, 8:59 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			shell/panelview.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6461	306bec5		Sep 6 2016, 8:34 AM	★	★
Diff 2	6467	412c2e4	rPLASMAWORKSPACE993983b3c31022add3032b88f729d624b30d7664	Sep 6 2016, 9:04 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
f2a4f56e2aae	51f26e323393	306bec560ee3	David Edmundson	Fix panelView updateEnabledBorders being skipped (Show More…)	Sep 5 2016, 10:31 PM