Differential D26656

Use QQC2 Page as base for Kirigami Page
ClosedPublic
Actions

Authored by ahiemstra on Jan 14 2020, 11:03 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:2829d2be5584: Use QQC2 Page as base for Kirigami Page
Summary

Instead of using Templates directly, use QQC2 page as base class for
Kirigami's Page. With Qt 5.14 something in the typing has become more
strict, so assigning Kirigami's Page to a property using QQC2 Page as
type fails.

This fixes Kirigami Gallery for me.

Test Plan

Kirigami Gallery works again.

Diff Detail

Repository
R169 Kirigami
Branch
page-is-not-page
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21103
Build 21121: arc lint + arc unit
ahiemstra created this revision.Jan 14 2020, 11:03 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptJan 14 2020, 11:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Jan 14 2020, 11:03 AM
mart accepted this revision.Jan 14 2020, 11:04 AM
This revision is now accepted and ready to land.Jan 14 2020, 11:04 AM
Closed by commit R169:2829d2be5584: Use QQC2 Page as base for Kirigami Page (authored by ahiemstra). · Explain WhyJan 14 2020, 11:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/Page.qml (3 lines)

Diff 73505

View Options

src/controls/Page.qml

Loading...