Differential D26632

Fix warning on ScrollablePage
ClosedPublic
Actions

Authored by apol on Jan 13 2020, 3:49 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:e2ebbe6f4ac9: Fix warning on ScrollablePage
Summary

At the moment we'll be going through all of the children objects and reassigning
the overlay as the parent. This is problematic because some objects won't allow
it, getting things like
ScrollablePage.qml:189: Error: Cannot assign QObject* to Action_QMLTYPE_11*

This patch changes it so only Items are reparented

Test Plan

Don't get the warnings anymore

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21061
Build 21079: arc lint + arc unit
apol created this revision.Jan 13 2020, 3:49 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJan 13 2020, 3:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jan 13 2020, 3:49 PM
mart accepted this revision.Jan 13 2020, 3:51 PM
This revision is now accepted and ready to land.Jan 13 2020, 3:51 PM
Closed by commit R169:e2ebbe6f4ac9: Fix warning on ScrollablePage (authored by apol). · Explain WhyJan 13 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/ScrollablePage.qml (8 lines)

Diff 73431

View Options

src/controls/ScrollablePage.qml

Loading...