Lazy load applet BusyIndicator
ClosedPublic

Authored by davidedmundson on Sep 5 2016, 10:40 AM.

Details

Summary

As a QQC, BusyIndicator contains quite a few objects; we always load it
for every applet even though some applets will never show it; this makes
it a perfect candidate for a Loader.

Test Plan

Created applet that constantly showed busy.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Lazy load applet BusyIndicator.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 5 2016, 10:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 5 2016, 10:42 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Sep 5 2016, 10:42 AM

+1 to the idea

The Desktop containment has some logic to ensure that once the BusyIndicator is loaded it doesn't unload it again in case the applet needs it again later.

This revision was automatically updated to reflect the committed changes.
broulik added inline comments.Sep 5 2016, 11:11 AM
containments/panel/contents/ui/main.qml
323

Shouldn't the z be on the Loader, though, to actually work?

davidedmundson added inline comments.Sep 5 2016, 12:38 PM
containments/panel/contents/ui/main.qml
323

yes, thanks. Fixed.