Port QRegExp to QRegularExpression
Needs ReviewPublic

Authored by ahmadsamir on Fri, Jan 10, 6:09 PM.

Details

Reviewers
ervin
Summary

QSortFilterProxyModel::setFilterFixedString() internally uses QRegExp
with QRegExp::FixedString syntax option; setFilterFixedString() was
ported by using setFilterRegularExpression(QRegularExpression::escape(string)),
this isn't perfect since QRegularExpression::escape() follows Perl quotemeta
algorithm, basically it escapes all characters in the pattern except for [A-Z],
[a-z], [0-9] and _; so for example a space ' ' is escaped too. See QRegularExpression
docs for the details.

Replace QSortFilterProxyModel::filterRegExp() with filterRegularExpression(),
the same for the relevant setters. Raise min. required Qt version to 5.12,
as that is where filterRegularExpression() was introduced.

Test Plan

make && ctest; some unit tests fail but they fail on master too.

Diff Detail

Repository
R4 Zanshin
Branch
l-qregular (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20942
Build 20960: arc lint + arc unit