Differential D26542

Return correct shape for Unmanaged clients
ClosedPublic
Actions

Authored by zzag on Jan 9 2020, 12:35 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R108:6e910c455d94: Return correct shape for Unmanaged clients
Summary

Currently EffectWindowImpl::shape() falls back to the frame geometry
because isX11Client() returns invalid value for Unmanaged clients.

BUG: 415475

Diff Detail

Repository
R108 KWin
Branch
dont-use-toplevel-is-client
Lint
Lint ErrorsExcuse: cppcheck is dumb
SeverityLocationCodeMessage
Errorinput.h:310CppcheckunknownMacro
Unit
No Unit Test Coverage
Build Status
Buildable 20845
Build 20863: arc lint + arc unit
zzag created this revision.Jan 9 2020, 12:35 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 9 2020, 12:35 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 9 2020, 12:35 PM
romangg accepted this revision.Jan 9 2020, 12:56 PM
This revision is now accepted and ready to land.Jan 9 2020, 12:56 PM
Closed by commit R108:6e910c455d94: Return correct shape for Unmanaged clients (authored by zzag). · Explain WhyJan 10 2020, 10:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects.cpp (5 lines)

Diff 73124

View Options

effects.cpp

Loading...