Differential D26529

[wallpapers/image] Put spinbox labels inside the spinboxes
ClosedPublic
Actions

Authored by ngraham on Jan 8 2020, 7:30 PM.

Details

Reviewers
mart
Group Reviewers
VDG
Plasma
Commits
R120:276eac85cf80: [wallpapers/image] Put spinbox labels inside the spinboxes
Summary

They look a little nicer this way, and can be localized more easily.

Test Plan

Before:


After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
inline-labels (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20823
Build 20841: arc lint + arc unit
ngraham created this revision.Jan 8 2020, 7:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 8 2020, 7:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 8 2020, 7:30 PM
mart accepted this revision.Jan 10 2020, 11:59 AM
This revision is now accepted and ready to land.Jan 10 2020, 11:59 AM
Closed by commit R120:276eac85cf80: [wallpapers/image] Put spinbox labels inside the spinboxes (authored by ngraham). · Explain WhyJan 10 2020, 1:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73092

View Options

wallpapers/image/imagepackage/contents/ui/config.qml

Loading...