Prevent drag & drop if left mouse button isn't pressed
ClosedPublic

Authored by tasossahanidis on Tue, Jan 7, 9:53 PM.

Details

Summary

It is possible to begin a drag & drop sequence using the forward/backward mouse buttons while moving the cursor.
For example:

QGraphicsSceneMouseEvent(GraphicsSceneMouseMove, buttons=ForwardButton|XButton2|ExtraButton2, pos=347,127, scenePos=347,127, screenPos=398,255)

This patch only allows drag & drop if the left mouse button is pressed.
Touch events should not be affected as they are handled separately.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tasossahanidis requested review of this revision.Tue, Jan 7, 9:53 PM
tasossahanidis created this revision.
ngraham accepted this revision.Wed, Jan 8, 4:12 PM
ngraham added a subscriber: ngraham.

Thanks for the patch! Works for me. Can you provide your email address so we can land it with correct authorship information?

This revision is now accepted and ready to land.Wed, Jan 8, 4:12 PM

Use git format-patch to hopefully add author information

Thanks for the patch! Works for me. Can you provide your email address so we can land it with correct authorship information?

Apologies, but using git format-patch doesn't seem to have added the information. How would I go about doing it? I can not find the option in the UI.

Just mention it in a comment here. For silly reasons, Phabricator disregards authorship in patches submitted using the web interface. It really wants you to use its arc command-line tool.

Use arc to submit the patch

I was trying to avoid it, mostly due to possible spambot reasons, so I tried arc. If it still doesn't work, then I will post a comment with it. I'll be sure to use arc next time from the beginning. Apologies again.

Thanks, that worked. I'm landing your patch now. Nice job, may it be the first of many!

This revision was automatically updated to reflect the committed changes.