RFC: Register Secret Agent on startup
ClosedPublic

Authored by davidedmundson on Jan 6 2020, 12:21 PM.

Details

Summary

Plasma NM's KDED is loaded on boot, but effectively does nothing until
the relevant plasmoid triggers the KDED.

This makes some sense for notifications and monitors, as it allows a
user to opt of a UI plasma network manager experience.

However, we want the secret agent as early in the boot as possible.
If a user is running NM, they definitely want this component active, and
if NM isn't running then registering the agent will no-op anyway.

DBus logs show that with this patch, I am retrieving my password and
a full 1500ms before org.kde.plasmanetworkmanagement.init is called and my initial wifi
connected 3s faster than before this patch.

We could potentially move this kded to phase 0 and get us even earlier.

Test Plan

Had a wifi with security set to "Store password for this user only"
Added dbus-monitor into my startup scripts

Logged in, wifi connected, logs showed a difference

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 6 2020, 12:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 6 2020, 12:21 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 6 2020, 12:21 PM
jgrulich accepted this revision.Jan 6 2020, 1:06 PM
This revision is now accepted and ready to land.Jan 6 2020, 1:06 PM
This revision was automatically updated to reflect the committed changes.