[Battery Monitor] Don't blink when battery is critical
ClosedPublic

Authored by broulik on Sun, Jan 5, 1:04 PM.

Details

Summary

Especially when you're almost out of juice you don't want to be wasting it blinking an icon causing excess repaints.
Also considering the critical percentage is hardcoded to 5% here and doesn't follow PowerDevil's setting.
Given battery critical notification is persistent and always on top of everything these days, you can't really miss the fact that you're almost ouf of power.

Test Plan
  • Fully charged: was hidden still
  • Not fully charged: was active now, never blinked, even when low

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sun, Jan 5, 1:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Jan 5, 1:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sun, Jan 5, 1:04 PM
anthonyfieroni accepted this revision.Sun, Jan 5, 1:22 PM
anthonyfieroni added a subscriber: anthonyfieroni.

Given battery critical notification is persistent and always on top of everything these days, you can't really miss the fact that you're almost ouf of power.

I investigate on it, but if you watch full screen video (Falkon) it does not appear on top, for some reason.

This revision is now accepted and ready to land.Sun, Jan 5, 1:22 PM

Works here. notify-send foo bar -u critical will show on top of everything.

ngraham accepted this revision.Sun, Jan 5, 4:07 PM
ngraham added a subscriber: ngraham.

Especially when you're almost out of juice you don't want to be wasting it blinking an icon causing excess repaints.

lol

This revision was automatically updated to reflect the committed changes.