Differential D26420

Add a logging category to smb ioslave
ClosedPublic
Actions

Authored by meven on Jan 4 2020, 2:53 PM.

Details

Reviewers
mlaurent
Group Reviewers
Frameworks
Commits
R320:1360c1f0e224: Add a logging category to smb ioslave

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jan 4 2020, 2:53 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptJan 4 2020, 2:53 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Jan 4 2020, 2:53 PM
mlaurent requested changes to this revision.Jan 4 2020, 3:14 PM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
smb/CMakeLists.txt
27

indent

smb/kio_smb.cpp
36

#include "..."

This revision now requires changes to proceed.Jan 4 2020, 3:14 PM
meven updated this revision to Diff 72749.Jan 4 2020, 3:18 PM

indent & ""

meven marked 2 inline comments as done.Jan 4 2020, 3:18 PM
mlaurent accepted this revision.Jan 4 2020, 6:38 PM
This revision is now accepted and ready to land.Jan 4 2020, 6:38 PM
meven updated this revision to Diff 72901.Jan 6 2020, 3:48 PM

rebase

Closed by commit R320:1360c1f0e224: Add a logging category to smb ioslave (authored by meven). · Explain WhyJan 6 2020, 3:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkio-extras.categories (1 line)
Msmb/CMakeLists.txt (5 lines)
Msmb/kio_smb.cpp (2 lines)

Diff 72902

View Options

kio-extras.categories

Loading...
View Options

smb/CMakeLists.txt

Loading...
View Options

smb/kio_smb.cpp

Loading...