Differential D26382

Port KCM menu away from PlasmaComponents
ClosedPublic
Actions

Authored by davidedmundson on Jan 3 2020, 8:25 AM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R116:5e055c1e1754: Port KCM menu away from PlasmaComponents
Summary

Plasma's menu can't handle being in a nested window and opens in the
wrong place.

Porting to QQC resolves this, and we ideally shouldn't be using this
import within a KCM.

BUG: 414762

Test Plan

Opened menu
It was in the right place
Clicking on delete still worked

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20566
Build 20584: arc lint + arc unit
davidedmundson created this revision.Jan 3 2020, 8:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2020, 8:25 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 3 2020, 8:25 AM
jgrulich accepted this revision.Jan 3 2020, 8:45 AM
This revision is now accepted and ready to land.Jan 3 2020, 8:45 AM
Closed by commit R116:5e055c1e1754: Port KCM menu away from PlasmaComponents (authored by davidedmundson). · Explain WhyJan 3 2020, 1:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm/qml/ConnectionItem.qml (23 lines)

Diff 72666

View Options

kcm/qml/ConnectionItem.qml

Loading...