[MPRIS Data Engine] Ignore players with CanControl false in multiplexer
AbandonedPublic

Authored by broulik on Dec 31 2019, 1:48 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

The multiplexer is responsible for global media control shortcuts which won't work with a player that isn't controllable.
The spec also says this property is not expected to change, so checking it initially once is compliant.

Test Plan

master-only, as last time I tampered with mpris in .5 minor update it broke some other non-standard compliant player...

  • Chrome's broken mpris impl doesn't steal keys from p-b-i anymore

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 31 2019, 1:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 31 2019, 1:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 31 2019, 1:48 PM
broulik edited the summary of this revision. (Show Details)Dec 31 2019, 1:52 PM
fvogt added a subscriber: fvogt.Jan 7 2020, 10:49 AM

IMO it should still be considered if it's the only one.

broulik abandoned this revision.Jan 17 2020, 11:20 AM

Superseded by D26702