When you type "/home/elvis" (without trailing slash) in the box and the select a project, is there still a slash added? If yes, looks good to me, otherwise please fix that :)

In D2632#48995, @brauch wrote:

When you type "/home/elvis" (without trailing slash) in the box and the select a project, is there still a slash added? If yes, looks good to me, otherwise please fix that :)

hmm no, without trailing slash the string becomes "/home/<project name>"...

You can just keep the old code and call adjusted(QUrl::NormalizePathSegments).

In D2632#48998, @brauch wrote:

You can just keep the old code and call adjusted(QUrl::NormalizePathSegments).

But the username is always going to be cut if there is no trailing slash, so we need to add it.

Another thing, I just noticed that ProjectSourcePage::locationChanged() has the same code, though I'm not sure how to reproduce the bug there. Do you thing it's worth to move this duplicated code in another function?

wait, before pushing this: if I cannot type "/foo/bar" into the location bar and then set a project name to get "/foo/bar/asdf", then something is broken. The duplicate "/" are just stylistically annoying, but a change in behavior as apparently introduced by this patch is imo not acceptable

Well before, both things were broken. ;)

In D2632#49247, @mwolff wrote:

wait, before pushing this: if I cannot type "/foo/bar" into the location bar and then set a project name to get "/foo/bar/asdf", then something is broken. The duplicate "/" are just stylistically annoying, but a change in behavior as apparently introduced by this patch is imo not acceptable

As far as I can see, this was already broken before this patch. /foo/bar would just become /foo//asdf, dropping bar.

ah ok nvm then