Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15
ClosedPublic
Actions

Authored by mlaurent on Dec 30 2019, 8:28 PM.

Details

Reviewers

dfaure
apol

Commits

Summary

Port endl method for compiling against qt5.15

Repository

R309 KService

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Dec 30 2019, 8:28 PM

apol added inline comments.

tests/pluginlocator/plugintest.cpp
60–66	std::endl should just work with cout.

tests/pluginlocator/plugintest.cpp
60–66	static QTextStream cout(stdout); it's a QTextStream

Ping ?:)

apol accepted this revision.Jan 3 2020, 2:53 PM

This revision is now accepted and ready to land.Jan 3 2020, 2:53 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/sycoca/vfolder_menu.cpp (2 lines)
M			tests/pluginlocator/plugintest.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72419	2037100		Dec 30 2019, 8:28 PM	★	★
Diff 2	72694	486af98	R309:128ed7ce3a1e45a69e763ca2377e45a9fec931df	Jan 3 2020, 4:02 PM	★	★