Differential D26299

endl is namespaced in qt5.15
ClosedPublic
Actions

Authored by mlaurent on Dec 30 2019, 8:22 PM.

Details

Reviewers
dfaure
apol
Commits
R280:99009fc60051: endl is namespaced in qt5.15
Summary

Port to Qt::endl in qt5.15

Diff Detail

Repository
R280 Prison
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Dec 30 2019, 8:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 30 2019, 8:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Dec 30 2019, 8:22 PM
apol added a subscriber: apol.Dec 31 2019, 6:39 PM
apol added inline comments.
src/tools/prison-datamatrix.cpp
39–40

Wouldn't make more sense to port to std::endl which as been around since forever? Or pass a '\n'.

mlaurent updated this revision to Diff 72510.Jan 1 2020, 9:21 AM

Use '\n'

apol accepted this revision.Jan 1 2020, 11:33 PM
This revision is now accepted and ready to land.Jan 1 2020, 11:33 PM
Closed by commit R280:99009fc60051: endl is namespaced in qt5.15 (authored by mlaurent). · Explain WhyJan 2 2020, 5:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tools/prison-datamatrix.cpp (3 lines)

Diff 72591

View Options

src/tools/prison-datamatrix.cpp

Loading...