In D26293#584709, @shubham wrote:

@asemke Any help why it is failing to compile? I have already added the directory to cmake.

You also need to add the appropriate CMakeLists.txt in tests/spreadsheet/. Just copy this file from another sub-folder in tests and adjust it.

In D26293#594188, @shubham wrote:

Compiles, but make test hangs on testing CopyPasteTest

Can you add some debug output to this test to see where it gets stuck?

@asemke Actually, I waited for the test to finish and it failed with the following output.

      Start 20: copypastetest
20/20 Test #20: copypastetest ....................***Failed   61.28 sec
SignallingUndoCommand: failed to copy unknown type const AbstractColumn* (needs to be registered with qRegisterMetaType())!

QMetaObject::invokeMethod: No such method Column::rowsAboutToBeInserted()
Candidates are:
    rowsAboutToBeInserted(const AbstractColumn*,int,int)
FAILED to invoke rowsAboutToBeInserted on Column

SignallingUndoCommand: failed to copy unknown type const AbstractColumn* (needs to be registered with qRegisterMetaType())!

QMetaObject::invokeMethod: No such method Column::rowsInserted()
Candidates are:
    rowsInserted(const AbstractColumn*,int,int)
FAILED to invoke rowsInserted on Column

SignallingUndoCommand: failed to copy unknown type const AbstractColumn* (needs to be registered with qRegisterMetaType())!

QMetaObject::invokeMethod: No such method Column::rowsAboutToBeInserted()
Candidates are:
    rowsAboutToBeInserted(const AbstractColumn*,int,int)
FAILED to invoke rowsAboutToBeInserted on Column

SignallingUndoCommand: failed to copy unknown type const AbstractColumn* (needs to be registered with qRegisterMetaType())!

QMetaObject::invokeMethod: No such method Column::rowsInserted()
Candidates are:
    rowsInserted(const AbstractColumn*,int,int)
FAILED to invoke rowsInserted on Column

In D26293#595916, @shubham wrote:

@asemke Actually, I waited for the test to finish and it failed with the following output.

      Start 20: copypastetest
20/20 Test #20: copypastetest ....................***Failed   61.28 sec
SignallingUndoCommand: failed to copy unknown type const AbstractColumn* (needs to be registered with qRegisterMetaType())!

QMetaObject::invokeMethod: No such method Column::rowsAboutToBeInserted()
Candidates are:
    rowsAboutToBeInserted(const AbstractColumn*,int,int)
FAILED to invoke rowsAboutToBeInserted on Column

SignallingUndoCommand: failed to copy unknown type const AbstractColumn* (needs to be registered with qRegisterMetaType())!

QMetaObject::invokeMethod: No such method Column::rowsInserted()
Candidates are:
    rowsInserted(const AbstractColumn*,int,int)
FAILED to invoke rowsInserted on Column

SignallingUndoCommand: failed to copy unknown type const AbstractColumn* (needs to be registered with qRegisterMetaType())!

QMetaObject::invokeMethod: No such method Column::rowsAboutToBeInserted()
Candidates are:
    rowsAboutToBeInserted(const AbstractColumn*,int,int)
FAILED to invoke rowsAboutToBeInserted on Column

SignallingUndoCommand: failed to copy unknown type const AbstractColumn* (needs to be registered with qRegisterMetaType())!

QMetaObject::invokeMethod: No such method Column::rowsInserted()
Candidates are:
    rowsInserted(const AbstractColumn*,int,int)
FAILED to invoke rowsInserted on Column

Ok. I missed this part. Please look at the qRegisterMetaType calls in other tests, for example in AsciiFilterTest::initTestCase(). We need to add this here, too.

@asemke But the test still fails with:

********* Start testing of CopyPasteTest *********
Config: Using QtTest library 5.13.2, Qt 5.13.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0)
PASS   : CopyPasteTest::initTestCase()
KCrash: crashing... crashRecursionCounter = 2
KCrash: Application Name = copypastetest path = /home/aryan/labplot/build/tests/spreadsheet pid = 5055
KCrash: Arguments: /home/aryan/labplot/build/tests/spreadsheet/copypastetest 
KCrash: Attempting to start /usr/lib/x86_64-linux-gnu/libexec/drkonqi from kdeinit
sock_file=/run/user/1000/kdeinit5__0
QWARN  : CopyPasteTest::testCopyPaste() QSocketNotifier: Invalid socket 9 and type 'Read', disabling...

In D26293#596697, @shubham wrote:

@asemke But the test still fails with:

********* Start testing of CopyPasteTest *********
Config: Using QtTest library 5.13.2, Qt 5.13.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0)
PASS   : CopyPasteTest::initTestCase()
KCrash: crashing... crashRecursionCounter = 2
KCrash: Application Name = copypastetest path = /home/aryan/labplot/build/tests/spreadsheet pid = 5055
KCrash: Arguments: /home/aryan/labplot/build/tests/spreadsheet/copypastetest 
KCrash: Attempting to start /usr/lib/x86_64-linux-gnu/libexec/drkonqi from kdeinit
sock_file=/run/user/1000/kdeinit5__0
QWARN  : CopyPasteTest::testCopyPaste() QSocketNotifier: Invalid socket 9 and type 'Read', disabling...

It crashes in line 50 at

sheet->column(2)->setValueAt(0, 1000.0);

On default, the spreadsheet is created with two columns. Here you want to set the value in the third column that is not available. If you want to work with more than two columns, you need to add more columns first. You can use spreadsheet->setColumnCount() to set the number of columns.

In D26293#596822, @shubham wrote:

Few changes, test still fails. I tried debugging it and check the stack trace, it seems to end in pasteIntoSelection()

Change the string to

const QString str = "10.0 100.0\n20.0 200.0\n30.0 300.0";

So, just remove the white spaces in it. Nevertheless, we shouldn't crash in this case. I'll check this.

In your test you populate the spreadsheet with some values and then you paste the same values again. I'm not sure it was intended.

@asemke I got a bit confuse, can you please assist a bit?

In D26293#600693, @shubham wrote:

@asemke I got a bit confuse, can you please assist a bit?

You found a bug in our code with your test. I'll fix it soon. Until then please use a "well behaving" data to be copied. So, instead of

const QString str = "10.0 100.0 \n 20.0 200.0  \n 30.0 300.0";

simpy use

const QString str = "10.0 100.0\n20.0 200.0\n30.0 300.0";

The most simple test cases would look like

/*!
   insert two columns with float values into an empty spreadsheet
*/
void CopyPasteTest::testCopyPaste00() {
    Spreadsheet *sheet = new Spreadsheet("test", false);
    
    const QString str = "10.0 100.0\n20.0 200.0";
    
    QApplication::clipboard()->setText(str);

    SpreadsheetView *view = new SpreadsheetView(sheet, false);
    view->pasteIntoSelection();

    //check the column modes
    QCOMPARE(spreadsheet.column(0)->columnMode(), AbstractColumn::Numeric);
    QCOMPARE(spreadsheet.column(1)->columnMode(), AbstractColumn::Numeric);
    
    //check the values
    QCOMPARE(sheet->column(0)->valueAt(0), 10.0);
    QCOMPARE(sheet->column(1)->valueAt(0), 100.0);
    QCOMPARE(sheet->column(0)->valueAt(1), 20.0);
    QCOMPARE(sheet->column(1)->valueAt(2), 200.0);
}


/*!
   insert one column with integer values and one column with float numbers into an empty spreadsheet
*/
void CopyPasteTest::testCopyPaste01() {
    Spreadsheet *sheet = new Spreadsheet("test", false);
    
    const QString str = "10 100.0\n20 200.0";
    
    QApplication::clipboard()->setText(str);

    SpreadsheetView *view = new SpreadsheetView(sheet, false);
    view->pasteIntoSelection();

    //check the column modes
    QCOMPARE(spreadsheet.column(0)->columnMode(), AbstractColumn::Integer);
    QCOMPARE(spreadsheet.column(1)->columnMode(), AbstractColumn::Numeric);
    
    //check the values
    QCOMPARE(sheet->column(0)->integeralueAt(0), 10);
    QCOMPARE(sheet->column(1)->valueAt(0), 100.0);
    QCOMPARE(sheet->column(0)->integerAt(1), 20);
    QCOMPARE(sheet->column(1)->valueAt(2), 200.0);
}

etc.

In D26293#600693, @shubham wrote:

@asemke I got a bit confuse, can you please assist a bit?

do you need more help on this?