Port away from serviceOwnerChanged signal
ClosedPublic
Actions

Authored by dvratil on Dec 30 2019, 1:19 AM.

Details

Reviewers

Commits

R165:8b879883f390: Port away from serviceOwnerChanged signal

Summary

Use QDBusServiceWatcher::service(Un)registered signals, since in
most cases we only need to see one or the other, rarely both and
we basically never want to execute the same code for both.

Diff Detail

Repository

R165 Akonadi

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20387
Build 20405: arc lint + arc unit

dvratil created this revision.Dec 30 2019, 1:19 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 30 2019, 1:19 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dvratil requested review of this revision.Dec 30 2019, 1:19 AM

Harbormaster completed remote builds in B20387: Diff 72357.Dec 30 2019, 1:19 AM

vkrause accepted this revision.Dec 30 2019, 9:03 AM

This revision is now accepted and ready to land.Dec 30 2019, 9:03 AM

Closed by commit R165:8b879883f390: Port away from serviceOwnerChanged signal (authored by dvratil). · Explain WhyDec 31 2019, 10:39 AM

This revision was automatically updated to reflect the committed changes.

dvratil mentioned this in R165:6ea76b4f1909: Partially revert porting away from serviceOwnerChanged signal.Jan 5 2020, 2:44 PM

Revision Contents
Changeset List

			Path	Packages
M			src/akonadictl/akonadistarter.h (5 lines)
M			src/akonadictl/akonadistarter.cpp (28 lines)
M			src/core/agentmanager.cpp (33 lines)
M			src/core/agentmanager_p.h (7 lines)
M			src/core/jobs/specialcollectionshelperjobs.cpp (30 lines)
M			src/core/jobs/specialcollectionshelperjobs_p.h (1 line)
M			src/core/servermanager.h (1 line)
M			src/core/servermanager.cpp (54 lines)
M			src/server/akonadi.h (6 lines)
M			src/server/akonadi.cpp (24 lines)
M			src/server/search/agentsearchinstance.h (7 lines)
M			src/server/search/agentsearchinstance.cpp (24 lines)
M			src/server/storage/itemretrievalmanager.h (3 lines)
M			src/server/storage/itemretrievalmanager.cpp (31 lines)