Differential D26279

ActionToolBar: Only show the overflow button if there are visible items in the menu
ClosedPublic
Actions

Authored by ahiemstra on Dec 29 2019, 7:26 PM.

Details

Reviewers
ngraham
apol
Group Reviewers
Kirigami
Commits
R169:8c09cfd92dbf: ActionToolBar: Only show the overflow button if there are visible items in the…
Summary

This fixes https://bugs.kde.org/show_bug.cgi?id=415412 , which was occuring because the
overflow button did not properly check to see if the actions in the menu were actually
visible.

BUG: 415412

Test Plan

The example code from the linked bug report now works correctly.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Dec 29 2019, 7:26 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 29 2019, 7:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Dec 29 2019, 7:26 PM
ahiemstra updated this revision to Diff 72344.
  • Remove unrelated flat change
ngraham accepted this revision.Dec 29 2019, 10:53 PM
ngraham added a subscriber: ngraham.

Fixes the issue, thanks!

This revision is now accepted and ready to land.Dec 29 2019, 10:53 PM
apol accepted this revision.Dec 30 2019, 5:53 PM
apol added a subscriber: apol.

Thanks!

Closed by commit R169:8c09cfd92dbf: ActionToolBar: Only show the overflow button if there are visible items in the… (authored by ahiemstra). · Explain WhyJan 3 2020, 10:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/ActionToolBar.qml (9 lines)

Diff 72672

View Options

src/controls/ActionToolBar.qml

Loading...