Differential D26277

KFilePlaceEditDialog: move logic into isIconEditable()
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 29 2019, 6:25 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R241:bdc2df9c1735: KFilePlaceEditDialog: move logic into isIconEditable()
Summary

Instead of relying on whether m_iconButton has been initialized
somewhere else in the code.

Test Plan

Make sure that editing icons is still allowed only for non-Trash places.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 29 2019, 6:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Dec 29 2019, 6:25 PM
ngraham accepted this revision.Jan 2 2020, 7:26 PM
This revision is now accepted and ready to land.Jan 2 2020, 7:26 PM
Closed by commit R241:bdc2df9c1735: KFilePlaceEditDialog: move logic into isIconEditable() (authored by elvisangelaccio). · Explain WhyJan 6 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72883

View Options

src/filewidgets/kfileplaceeditdialog.cpp

Loading...