Details
- Reviewers
mutlaqja - Commits
- R321:d67b2be772b5: Fix multiple warnings
Diff Detail
- Repository
- R321 KStars
- Branch
- warnings
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20341 Build 20359: arc lint + arc unit
Great work, please check the comment!
| kstars/fitsviewer/fpackutil.c | ||
|---|---|---|
| 1026 ↗ | (On Diff #72275) | The bracket style we follow is different. We use ANSI style. I suggest create ~/.astylerc file and add to it the following: --style=allman Of course, you need to install astyle on your system. in QtCreator, you can configure it so that it applies that style everything it saves the file.. this way it will always be in the same coding style used in the project. |
| kstars/hips/hipsmanager.cpp | ||
| 390 ↗ | (On Diff #72275) | Can you check when this was introduced in Qt as well? |
| kstars/hips/hipsrenderer.cpp | ||
| 167 ↗ | (On Diff #72275) | Same as above. |
| kstars/skyqpainter.cpp | ||
| 913 ↗ | (On Diff #72275) | Same issue about Qt version check. I think by next year (around April/May), we can increase the requirement for KStars Qt version and then get rid of these #if s |
| kstars/ekos/scheduler/scheduler.cpp | ||
|---|---|---|
| 1161 ↗ | (On Diff #72275) | Introduced in Qt 5.13 |
Btw, you don't have to remove your changes completely. You can enclose them in #if statements. For example
#if QT_VERSION >= QT_VERSION_CHECK(5,13,0)
jobs.swapItemsAt(currentRow, destinationRow);
#else
jobs.swap(currentRow, destinationRow);
#endif
This way we fix the warning on more recent Qt versions and also it is a reminder for us to remove this check once Qt 5.13 becomes the minimum supported version by KStars, so it's a double win. You can do this for all the changes you proposed above.
Haha, i am an old player, I have a developer account already. By the way, thanks for committing.