Modify focus plot to include sample number
ClosedPublic

Authored by murveit on Dec 27 2019, 7:57 AM.

Details

Reviewers
mutlaqja
Summary

The sample number is rendered inside the focus v_graph point, so one can see
the order the samples were taken. There's also a bug fix to a qCDebug.

Test Plan

Run autofocus, and look at the v_graph. Instead of little filled red circles with white borders, you should
now see (larger) red numbers indicating the order of focus samples, with white circles
around them. The first plotted point should show 1, the next 2, and so on.

Diff Detail

Repository
R321 KStars
Branch
plot-number (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20320
Build 20338: arc lint + arc unit
murveit created this revision.Dec 27 2019, 7:57 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 27 2019, 7:57 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Dec 27 2019, 7:57 AM

This looks good! However, I think the numbers can be easily read if the circle background was opaque instead of transparent?

murveit updated this revision to Diff 72257.Dec 27 2019, 5:13 PM

Made the background white.

mutlaqja accepted this revision.Dec 28 2019, 7:35 AM
This revision is now accepted and ready to land.Dec 28 2019, 7:35 AM

Tried to land this but failed.. it said: Email address has an invalid domain : murveit@hys-macbook-pro.home

Can you check Arcanist/GIT config and correct the user name?

murveit updated this revision to Diff 72276.Dec 28 2019, 7:40 AM

Previous submission had bad user.email, trying again.

mutlaqja accepted this revision.Dec 28 2019, 7:43 AM
mutlaqja closed this revision.