Differential D26230

Add button to toggle sidebar in fullscreen mode
ClosedPublic
Actions

Authored by abcdjdj on Dec 26 2019, 9:59 AM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Gwenview
Commits
R260:db6ca614a41e: Add button to toggle sidebar in fullscreen mode
Summary

Previously, there was no way to toggle the sidebar in
fullscreen view mode except for the keyboard shortcut F4. This patch
adds a button to toggle the sidebar from the fullscreen toolbar.

BUG: 414694
FIXED-IN: 20.04.0

Test Plan

Tested the button in fullscreen (view) mode. Button works
as expected, and preserves existing behavior of all other sidebar
toggle mechanisms as well.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abcdjdj created this revision.Dec 26 2019, 9:59 AM
Restricted Application added a project: Gwenview. · View Herald TranscriptDec 26 2019, 9:59 AM
abcdjdj requested review of this revision.Dec 26 2019, 9:59 AM
ngraham accepted this revision.Dec 26 2019, 3:18 PM

Very nice change, and very nice first patch! I love it when something like this is simple.

This revision is now accepted and ready to land.Dec 26 2019, 3:18 PM
ngraham edited the summary of this revision. (Show Details)Dec 26 2019, 3:18 PM
Closed by commit R260:db6ca614a41e: Add button to toggle sidebar in fullscreen mode (authored by abcdjdj, committed by ngraham). · Explain WhyDec 26 2019, 4:03 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Dec 26 2019, 4:03 PM

May it be the first of many. :)

abcdjdj added a comment.Dec 27 2019, 6:03 AM
In D26230#583268, @ngraham wrote:

Very nice change, and very nice first patch! I love it when something like this is simple.

In D26230#583282, @ngraham wrote:

May it be the first of many. :)

Thanks Nate :)
I'm very excited to understand and get acquainted with the KDE code-base. Hoping to send in more patches soon. Happy holidays! :)

Revision Contents
Changeset List

PathPackages
Mapp/fullscreencontent.cpp (2 lines)

Diff 72214

View Options

app/fullscreencontent.cpp

Loading...