| winterz | |
| vkrause |
| KDE PIM |
The code compiles and all unit tests pass, except for five ones, but
they fail on master too.
Note that for \x escape sequences have more than two hex digits, the
pattern must be wrapped in curly braces, i.e. \x{nnnn}, see:
https://perldoc.perl.org/perlre.html
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
\xnn can be used with one or two hex digits, for \x escape sequences with more than two hex digits one must use \x{nnnn}
| src/compat.cpp | ||
|---|---|---|
| 57 | If I understand correctly, this creates a QRegularExpression, compiles the pattern, performs the match, then throws the object and compiled pattern away. Should this declare a constant, so construction and pattern compilation only happen once? | |
| src/compat.cpp | ||
|---|---|---|
| 57 | hmm, tbh I am not sure whether that would be beneficial or not; it depends on how many times createCompat() is called, looking at the code it's only called by ICalFormatImpl::populate(), but I don't know how many external users do call that function. | |
| src/compat.cpp | ||
|---|---|---|
| 57 | Right, it's probably not worth it in this case. I don't think this is a particularly hot path, and making it static has a cost too (non-sharable runtime memory). | |