[System Tray] Silence warning
ClosedPublic

Authored by davidedmundson on Aug 27 2016, 6:34 PM.

Details

Summary

internalSystray is (for some reason) only set in Component.onCompleted. This fixes the warning this causes.

Test Plan

I guess not binding directly is due to some native interface initialization order foo?

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6325.Aug 27 2016, 6:34 PM
broulik retitled this revision from to [System Tray] Silence warning.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 27 2016, 6:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson commandeered this revision.Aug 28 2016, 1:03 PM
davidedmundson added a reviewer: broulik.
davidedmundson added a subscriber: davidedmundson.

I guess not binding directly is due to some native interface initialization order foo?

The problem with assuming the original author had a valid reason for whatever they were doing is we end up just building hacks on top of code for no reason. Then it escalates into something unmaintainable. There is no need for any "initialisation order foo", though the existing code managed to create one.

I fixed the system tray. Patch incoming.

mart added a subscriber: mart.Aug 29 2016, 9:05 AM

the thing is that internalSystray can be assigned at any moment, since being usually its config after the one of the container in appletsrc, usually when the applet container is started and initialized, the systray containment still doesn't exist

kai, you can ship this.

I can't approve it, as I broke phab.

mart accepted this revision.Aug 29 2016, 11:21 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 29 2016, 11:21 AM
mart added a comment.Aug 29 2016, 11:21 AM

accept was still enabled for me

This revision was automatically updated to reflect the committed changes.