Differential D26016

[KeySequenceHelper] Work around Meta modifier behavior
ClosedPublic
Actions

Authored by broulik on Dec 15 2019, 1:13 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R296:4306fb8f4e19: [KeySequenceHelper] Work around Meta modifier behavior
Summary

When I press my Meta key, I get a Key_Super_L *without* a Meta key confusing the rest of the modifier handling in this class.
To work around this, explicitly set MetaModifier when the key is pressed and remove it

Test Plan
  • I can use Meta for modifiers properly now

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 15 2019, 1:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 15 2019, 1:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Dec 15 2019, 1:13 PM
broulik updated this revision to Diff 71596.Dec 15 2019, 1:21 PM
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
  • Turns out it's not QtQuick
davidedmundson accepted this revision.Dec 15 2019, 3:26 PM
This revision is now accepted and ready to land.Dec 15 2019, 3:26 PM
Closed by commit R296:4306fb8f4e19: [KeySequenceHelper] Work around Meta modifier behavior (authored by broulik). · Explain WhyApr 9 2020, 1:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79709

View Options

src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

Loading...