... but Qt XCB knows, such as Notifications type.
This ensures QXcbWindow keeps the correct window types around.
Only for types that aren't in NET WM like OSD and Critical Notifications will it have to fall back to KWindowSystem.
It also just uses it directly on Wayland.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R242:192a50fe8c3c: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags…
- OSD and notifications still work
- Window type no longer changes when changing messing with window flags on a notification window, obsoleting D25832
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think we need to look at our direction of KWindowSystem long term, but in terms of what actually happens this makes complete sense.
Better to set the right type once, than to constantly set and reset the same thing, sending garbage data over the wire.
| src/plasmaquick/dialog.cpp | ||
|---|---|---|
| 728 | Personally, I prefer Q_ASSERT + return as you get to catch when a future mistake happens. (not that it really matters...it is unreachable) | |