Differential D2598

Do not hardcode font for street styles to Arial, but use generic map font
ClosedPublic
Actions

Authored by kossebau on Aug 26 2016, 11:40 PM.

Details

Reviewers
sanjibanb
nienhueser
Group Reviewers
Marble
Commits
R34:c3dee96ba672: Do not hardcode font for street styles to Arial, but use generic map font
Summary
  • make static methods member methods for access to members (e.g. default font member)
  • remove default arg value QFont(QLatin1String("Arial")
  • reuse same QFont object more (implicitely shared data)

Seems vector tiles are cached somehow, so a new font is
not picked up instantly

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 6313.Aug 26 2016, 11:40 PM
kossebau retitled this revision from to Do not hardcode font for street styles to Arial, but use generic map font.
kossebau updated this object.
kossebau added reviewers: Marble, nienhueser, sanjibanb.
nienhueser accepted this revision.Sep 9 2016, 3:56 AM
nienhueser edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Sep 9 2016, 3:56 AM
Closed by commit R34:c3dee96ba672: Do not hardcode font for street styles to Arial, but use generic map font (authored by kossebau). · Explain WhySep 9 2016, 11:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/marble/StyleBuilder.cpp (134 lines)

Diff 6588

View Options

src/lib/marble/StyleBuilder.cpp

Loading...