Differential D2597

Allows only one level of recursion
ClosedPublic
Actions

Authored by ivan on Aug 26 2016, 9:39 PM.

Details

Reviewers
cullmann
sstjames
Group Reviewers
Kate
Commits
R39:51dddd021ef0: Allows only one level of recursion
Summary

When one enters the underscore in the vim bar,
it infinitely recurses trying to process the
key pressed event [1].

This patch allows only one level of recursion.

[1] https://bugs.kde.org/show_bug.cgi?id=364650

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan updated this revision to Diff 6312.Aug 26 2016, 9:39 PM
ivan retitled this revision from to Allows only one level of recursion.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptAug 26 2016, 9:39 PM
sstjames edited edge metadata.EditedAug 27 2016, 8:27 AM

Thanks for investigating Ivan, and sorry for the inconvenience this has caused.

I'm still completely unable to reproduce this, but the patch seems to cause no problems and if it fixes this issue for you, please go ahead and commit!

Closed by commit R39:51dddd021ef0: Allows only one level of recursion (authored by ivan). · Explain WhyAug 27 2016, 8:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6314

View Options

src/vimode/emulatedcommandbar/emulatedcommandbar.cpp

Loading...