| davidedmundson | |
| ngraham |
| Plasma |
We're currently using an ugly hack in our main.qml file to make the QuickWidget that shows theme info have it's color the same as the QWidget it's nested in.
The hack is not only ugly but totally breaks apart with any widget style that's not Breeze.
The correct solution has always been to just set the QuickWidget to be transparent. It now blends with every widget style and we don't need a hack anymore.
Example: Oxygen
Before:
After:
| No Linters Available |
| No Unit Test Coverage |
| Buildable 19819 | |
| Build 19837: arc lint + arc unit |
Excellent solution. Question: do we even need a Rectangle at all if it's going to be transparent? Can it just be an Item?
Shipit! Stable branch please.
BTW, GridViewKCM, SimpleKCM, and ScrollViewKCM seem like they needs the same treatment, now that I'm navigating System Settings with the Oxygen style to test this.
There might be an unfortunate side effect: https://forum.qt.io/topic/57634/qt-wa_alwaysstackontop-influences-font-rendering-in-qml/5
Which is acceptable here in my opinion since blending doesn't even exist with Breeze, but could become a problem if present everywhere and in prominent places.
Going to have to be a no from me since the lack of font anti-aliasing looks pretty bad with darker color schemes. Not sure if it's worth it to report the bug to Qt.