Differential D25953

Ignore parent scopes that are in the process of being removed
ClosedPublic
Actions

Authored by apol on Dec 13 2019, 2:36 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:208b94365ce0: Ignore parent scopes that are in the process of being removed
Summary

When we destroy a colorscope, all children will try to reparent. This patch
makes it so they never pick an object if it's being removed.

Test Plan

The logout screen greeter and kscreenlocker doesn't crash anymore
upon close.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Dec 13 2019, 2:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 13 2019, 2:36 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Dec 13 2019, 2:36 PM
mart accepted this revision.Dec 13 2019, 3:18 PM
This revision is now accepted and ready to land.Dec 13 2019, 3:18 PM
Closed by commit R242:208b94365ce0: Ignore parent scopes that are in the process of being removed (authored by apol). · Explain WhyDec 13 2019, 4:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71457

View Options

src/declarativeimports/core/colorscope.h

Loading...
View Options

src/declarativeimports/core/colorscope.cpp

Loading...