Move all the code that was supposed to be the applet into
Plasmoid.fullReprensentation. Otherwise only the compact representation
is shown which is just the icon.
BUG: 361928
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Thanks, but this is isn't the right fix
comic applet hasn't changed which means it's a change in plasma-framework (probably) fixing it here will still leave potentially 3rd party applets broken, and if it is plasma-framework will still leave it broken for users of Plasma 5.6 or older.
In theory what should happen is the root item will be used as the full representation if no fullRepresentation exists.
Once fixed, we can merge this patch anyway, as I hate that undocumented magic above, and this is a lot more readable.
Comment Actions
Edit:
I was wrong about this being a regression. It seems this has always been here.
the switch between showing compact and full is:
Math.max(minimumWidth, Math.min(centerLayout.comicData.image.nativeWidth * 0.6, implicitWidth)); or implicitWidth
both minimumWidth and implicitWidth are fricking enormous.
Which means by default we'll show the compact on startup, and until the plasmoid is made even bigger than the already huge default size.
(and in fact dragging it larger in both directions does reveal the components correctly)
Your patch works by breaking the binding on minimumWidth used in the switchWidth, so that it now always shows the full version.
Which is replacing it by a different bug.
| applets/comic/package/contents/ui/main.qml | ||
|---|---|---|
| 33 | you've broken this binding. minimumWidth is no longer declared within this scope. though this whole line makes little sense anwyay - see comment below. | |