Differential D25937

pic: Fix Invalid-enum-value undefined behaviour
ClosedPublic
Actions

Authored by aacid on Dec 12 2019, 10:28 PM.

Details

Reviewers
dfaure
Commits
R287:c60e77c048d3: Add support for modern Gimp images/XCF files
R287:f03739f22213: pic: Fix Invalid-enum-value undefined behaviour
Summary

Instead of directly casting the quint8 to PicChannelEncoding we just store the quint8
and compare it to the possible PicChannelEncoding values when needed

oss-fuzz/19344

Diff Detail

Repository
R287 KImageFormats
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19769
Build 19787: arc lint + arc unit
aacid created this revision.Dec 12 2019, 10:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 12 2019, 10:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Dec 12 2019, 10:28 PM
dfaure accepted this revision.Dec 14 2019, 11:45 AM
dfaure added a subscriber: dfaure.

Interesting case of "type safety being worse" ;-)

This revision is now accepted and ready to land.Dec 14 2019, 11:45 AM
aacid closed this revision.Dec 14 2019, 8:05 PM

Revision Contents
Changeset List

PathPackages
Msrc/imageformats/pic.cpp (4 lines)
Msrc/imageformats/pic_p.h (2 lines)

Diff 71401

View Options

src/imageformats/pic.cpp

Loading...
View Options

src/imageformats/pic_p.h

Loading...