Differential D25924

fix static linking on e.g. macOS
AbandonedPublic
Actions

Authored by cullmann on Dec 12 2019, 3:59 PM.

Details

Reviewers
vkrause
Summary

Before, linking fails for me here (static Qt)

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19754
Build 19772: arc lint + arc unit
cullmann created this revision.Dec 12 2019, 3:59 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 12 2019, 3:59 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
cullmann requested review of this revision.Dec 12 2019, 3:59 PM
vkrause added a comment.Dec 12 2019, 4:05 PM

This looks wrong though, QtNetwork is not used in the public interface, is it? And the cmake config files are supposed to propagate private link libraries in case of static linking too I think, otherwise LINK_PRIVATE could basically never work, no?

cullmann added a comment.Dec 12 2019, 4:07 PM

Therefore I made this review request ;)
For me, for Qt 5.14 static linked, it doesn't seem to propagate.
I am not sure why that worked before thought.

cullmann added a comment.Dec 12 2019, 4:33 PM

If you think that is just a Qt issue, we can close this again =)
In-house we will just patch this :-0 Debugging the static linking in Qt is too much work.

cullmann abandoned this revision.Dec 12 2019, 5:04 PM

Let's just close that.
If I have enough time somewhen, will report a Qt bug (or try .1)

Revision Contents
Changeset List

PathPackages
Msrc/lib/CMakeLists.txt (2 lines)

Diff 71367

View Options

src/lib/CMakeLists.txt

Loading...